[PATCH 7/9] powerpc: add MPC837x RDB platform support

[Stephen Rothwell]

Hi Kim,

Again, a bit late but a couple of comments.

On Thu, 24 Jan 2008 20:47:11 -0600 Kim Phillips <kim.phillips at freescale.com> wrote:
>
> +static struct of_device_id mpc837x_ids[] = {

Make this __initdata, please.

> +static void __init mpc837x_rdb_init_IRQ(void)
> +{
> +	struct device_node *np;
> +
> +	np = of_find_compatible_node(NULL, NULL, "fsl,ipic");
> +	if (!np)
> +		return;
> +
> +	ipic_init(np, 0);

You need an of_node_put(np) here.

> +static int __init mpc837x_rdb_probe(void)
> +{
> +	unsigned long root = of_get_flat_dt_root();
> +
> +	return of_flat_dt_is_compatible(root, "fsl,mpc8377rdb") ||
> +	       of_flat_dt_is_compatible(root, "fsl,mpc8378rdb") ||
> +	       of_flat_dt_is_compatible(root, "fsl,mpc8379rdb");

You need to include asm/prom.h to use the flattened device tree accessors.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080205/95d60f70/attachment.pgp>