[PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

Jeff Garzik jgarzik at pobox.com
Sat Feb 2 05:40:34 EST 2008


Anton Vorontsov wrote:
> - uccf should be set to NULL to not double-free memory on
>   subsequent calls;
> - ind_hash_q and group_hash_q lists should be initialized in the
>   probe() function, instead of struct_init() (called by open()),
>   otherwise there will be an oops if ucc_geth_driver removed
>   prior 'ifconfig ethX up';
> - add unregister_netdev();
> - reorder geth_remove() steps.
> 
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
> ---
> 
> Hi Li,
> 
> You kinda promised that these two patches would hit 2.6.25... ;-)
> 
> I've rebased the patches so they apply cleanly on the current tree.
> 
> Thanks,
> 
>  drivers/net/ucc_geth.c |   17 ++++++++++-------
>  1 files changed, 10 insertions(+), 7 deletions(-)

applied 1-2





More information about the Linuxppc-dev mailing list