[PATCH] [POWERPC] Xilinx: hwicap driver

[Stephen Neuendorffer]

Thanks,

I realized that on the way home..  That's what I get for trying to
finish something quickly before leaving.. :)

Steve

> -----Original Message-----
> From: Nathan Lynch [mailto:ntl at pobox.com]
> Sent: Thursday, January 31, 2008 9:56 PM
> To: Stephen Neuendorffer
> Cc: linuxppc-dev at ozlabs.org; grant.likely at secretlab.ca;
jacmet at sunsite.dk
> Subject: Re: [PATCH] [POWERPC] Xilinx: hwicap driver
> 
> Stephen Neuendorffer wrote:
> >
> > +static ssize_t
> > +hwicap_read(struct file *file, char *buf, size_t count, loff_t
*ppos)
> > +{
> > +	struct hwicap_drvdata *drvdata = file->private_data;
> > +	ssize_t bytes_to_read = 0;
> > +	u32 *kbuf;
> > +	u32 words;
> > +	u32 bytes_remaining;
> > +	int status;
> > +
> > +        spin_lock(&hwicap_spinlock);
> > +	if (drvdata->is_accessing)
> > +		return -EBUSY;
> 
> Need to unlock before returning (several places in this patch).
>