[PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

Zhang Wei Wei.Zhang at freescale.com
Fri Feb 1 15:51:21 EST 2008


Hi, Jon, 

> -----Original Message-----
> From: Loeliger Jon 
> 
> Zhang Wei wrote:
> > Signed-off-by: Zhang Wei <wei.zhang at freescale.com>
> > ---
> >  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   13 +++++++++++++
> >  1 files changed, 13 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts 
> b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > index 556a9ca..1a0fce5 100644
> > --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > @@ -25,6 +25,7 @@
> >  		serial1 = &serial1;
> >  		pci0 = &pci0;
> >  		pci1 = &pci1;
> > +		rapidio0 = &rapidio0;
> >  	};
> >  
> >  	cpus {
> > @@ -499,4 +500,16 @@
> >  				  0 00100000>;
> >  		};
> >  	};
> > +
> > +	rapidio0: rapidio at f80c0000 {
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		compatible = "fsl,rapidio-delta";
> > +		reg = <f80c0000 20000>;
> > +		ranges = <0 0 c0000000 0 20000000>;
> > +		interrupt-parent = <&mpic>;
> > +		/* err_irq bell_outb_irq bell_inb_irq
> > +			msg1_tx_irq msg1_rx_irq	msg2_tx_irq 
> msg2_rx_irq */
> > +		interrupts = <30 2 31 2 32 2 35 2 36 2 37 2 38 2>;
> > +	};
> >  };
> 
> The 8641 DTS file has been converted to /dts-v1/ format now.
> Please rewrite this patch with explicit hex numbers for
> addresses, even if 0x0, and decimal for IRQs.
> 
I have seen other nodes in mpc8641_hpcn.dts still use old style.
 Is it better to create an another new patch for correcting the style all?

Cheers!
Wei



More information about the Linuxppc-dev mailing list