[PATCH] ibmveth: use consistent types
David Miller
davem at davemloft.net
Wed Dec 31 16:49:59 EST 2008
From: Stephen Rothwell <sfr at canb.auug.org.au>
Date: Wed, 31 Dec 2008 14:02:25 +1100
> These variables are only used with an interface involving "unsigned
> long" and the macros are only used with these variables. This change
> will prevent some warnings when we change u64 to "unsigned long long".
>
> This code is only built for 64bit powerpc, so the transformation is
> really a noop.
>
> Signed-off-by: Stephen Rothwell <sfr at canb.auug.org.au>
I'd prefer if the types were to remain 32-bit portable.
Doing things like this is just a problem waiting to happen,
either for the first person who actually finds a need and
a way to use this driver on 32-bit or the person who cut and
pastes this code into their driver which should work on both
32-bit and 64-bit.
Patch not applied.
More information about the Linuxppc-dev
mailing list