[PATCH 6/6] ucc_geth: Remove UGETH_FILTERING dead code

Li Yang leoli at freescale.com
Mon Dec 22 22:13:43 EST 2008


On Sun, Dec 21, 2008 at 11:23 AM, Timur Tabi <timur at freescale.com> wrote:
> On Thu, Dec 18, 2008 at 12:23 PM, Anton Vorontsov
> <avorontsov at ru.mvista.com> wrote:
>> The code appears to be dead: nobody call these functions, plus build
>> breaks when UGETH_FILTERING is enabled:
>
> I general, I agree with patches like this, but I'd like to hear from
> Leo first why this code was written in the first place before I can
> ack it.

The code was there to test the frame filtering feature which probably
can be used in multicast and VLAN support.  I didn't remove it because
it could be a base for whoever interested to implement a general frame
filtering framework or custom features.  Given the fact that unused
code can easily become broken.  I agree that it can be removed for
now.

Acked-by: Li Yang <leoli at freescale.com>



More information about the Linuxppc-dev mailing list