[PATCH] Fix corruption error in rh_alloc_fixed()

[Kumar Gala]

On Dec 9, 2008, at 8:28 AM, Guillaume Knispel wrote:

> There is an error in rh_alloc_fixed() of the Remote Heap code:
> If there is at least one free block blk won't be NULL at the end of  
> the
> search loop, so -ENOMEM won't be returned and the else branch of
> "if (bs == s || be == e)" will be taken, corrupting the management
> structures.
>
> Signed-off-by: Guillaume Knispel <gknispel at proformatique.com>
> ---
> Fix an error in rh_alloc_fixed() that made allocations succeed when
> they should fail, and corrupted management structures.
>
> diff --git a/arch/powerpc/lib/rheap.c b/arch/powerpc/lib/rheap.c
> index 29b2941..45907c1 100644
> --- a/arch/powerpc/lib/rheap.c
> +++ b/arch/powerpc/lib/rheap.c
> @@ -556,6 +556,7 @@ unsigned long rh_alloc_fixed(rh_info_t * info,  
> unsigned long start, int size, co
> 		be = blk->start + blk->size;
> 		if (s >= bs && e <= be)
> 			break;
> +		blk = NULL;
> 	}
>
> 	if (blk == NULL)

applied

- k