[PATCH] powerpc/iseries: viodasd needs to depend on CONFIG_BLOCK
Jens Axboe
jens.axboe at oracle.com
Wed Dec 17 19:02:11 EST 2008
On Wed, Dec 17 2008, Stephen Rothwell wrote:
> Otherwise you get lot of errors like these:
>
> drivers/block/viodasd.c:72: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_open':
> drivers/block/viodasd.c:135: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_release':
> drivers/block/viodasd.c:184: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c: In function 'viodasd_getgeo':
> drivers/block/viodasd.c:209: error: dereferencing pointer to incomplete type
> drivers/block/viodasd.c:214: error: implicit declaration of function 'get_capacity'
> drivers/block/viodasd.c: At top level:
> drivers/block/viodasd.c:222: error: variable 'viodasd_fops' has initializer but incomplete type
> drivers/block/viodasd.c:223: error: unknown field 'owner' specified in initializer
>
> Discovered by a randconfig build.
>
> Signed-off-by: Stephen Rothwell <sfr at canb.auug.org.au>
> ---
> arch/powerpc/platforms/iseries/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/platforms/iseries/Kconfig b/arch/powerpc/platforms/iseries/Kconfig
> index 45ffd8e..ed3753d 100644
> --- a/arch/powerpc/platforms/iseries/Kconfig
> +++ b/arch/powerpc/platforms/iseries/Kconfig
> @@ -9,6 +9,7 @@ menu "iSeries device drivers"
>
> config VIODASD
> tristate "iSeries Virtual I/O disk support"
> + depends on BLOCK
> help
> If you are running on an iSeries system and you want to use
> virtual disks created and managed by OS/400, say Y.
> --
> 1.6.0.5
Indeed, looks good. I trust the ppc folks will carry this one? If so,
feel free to add my acked-by to this.
--
Jens Axboe
More information about the Linuxppc-dev
mailing list