[PATCH 7/8] less use of NODE_DATA()

Paul Mackerras paulus at samba.org
Tue Dec 16 16:16:46 EST 2008


Dave Hansen writes:

> The use of NODE_DATA() in the ppc init code is fragile.  We use
> it for some nodes as we are initializing others.  As the loop
> initializing them has gotten more complex and broken out into
> several functions it gets harder and harder to remember how
> this goes.

With this one applied (it needed some adjustment because of
differences in dbg() lines), I get a hang on boot on a POWER6
partition after printing:

Linux version 2.6.28-rc8-test (paulus at drongo) (gcc version 4.3.2 (Debian 4.3.2-1) ) #64 SMP Tue Dec 16 16:14:45 EST 2008
[boot]0012 Setup Arch
Node 0 Memory:
Node 1 Memory: 0x0-0x100000000

It appears that this partition has all its memory on node 1.  It did
boot OK with your patches up to 5/8 applied.

Paul.



More information about the Linuxppc-dev mailing list