[PATCH 15/16] powerpc/mm: Rework usage of _PAGE_COHERENT/NO_CACHE/GUARDED

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Dec 16 08:05:57 EST 2008


On Tue, 2008-12-16 at 08:03 +1100, Michael Ellerman wrote:
> On Mon, 2008-12-15 at 14:54 -0600, Kumar Gala wrote:
> > >
> > > #ifndef __ASSEMBLY__
> > > +
> > > +/*
> > > + * Macro to mark a page protection value as "uncacheable".
> > > + */
> > > +
> > > +#define _PAGE_CACHE_CTL	(_PAGE_COHERENT | _PAGE_COHERENT | _PAGE_COHERENT | \
> > > + 			 _PAGE_WRITETHRU)
> > 
> > we like coherent so much we set it thrice?
> 
> That makes it really-really-really coherent.

Actually the mask is used to remove those bits so not quite :-)

Should be all WIMG, I'll send a fix.

Cheers,
Ben.





More information about the Linuxppc-dev mailing list