[PATCH] AMCC Crypto4xx Device Driver v4]

[Kim Phillips]

On Fri, 5 Dec 2008 06:41:13 +0100
Stefan Roese <sr at denx.de> wrote:

> On Friday 05 December 2008, Kim Phillips wrote:
> > > diff --git a/arch/powerpc/boot/dts/canyonlands.dts
> > > b/arch/powerpc/boot/dts/canyonlands.dts index 79fe412..b0f0096 100644
> > > --- a/arch/powerpc/boot/dts/canyonlands.dts
> > > +++ b/arch/powerpc/boot/dts/canyonlands.dts
> > > @@ -116,6 +116,13 @@
> > >  			dcr-reg = <0x010 0x002>;
> > >  		};
> > >
> > > +		CRYPTO: crypto at 180000 {
> > > +			compatible = "amcc,ppc460ex-crypto", "amcc,ppc4xx-crypto";
> > > +			reg = <4 0x00180000 0x80400>;
> > > +			interrupt-parent = <&UIC0>;
> > > +			interrupts = <0x1d 0x4>;
> >
> > that's odd, according to the current canyonlands.dts, irq 0x1d is
> > already assigned to UART2 (and the request_irq this driver makes
> > doesn't specify a shared flag).
> 
> UART2 is using irq 0x1d from UIC1. Using 0x1d/UIC0 is correct for Security 
> EIP-94 according to the latest users manual. No sharing needed.

ok, I didn't notice the machine had four interrupt controllers (!),
thanks.

Kim