[PATCH] powerpc: Fix build of 4xx simple platforms without CONFIG_PCI

Benjamin Herrenschmidt benh at kernel.crashing.org
Mon Dec 8 16:38:14 EST 2008


> > --- linux-work.orig/arch/powerpc/platforms/40x/ppc40x_simple.c	2008-12-08 15:51:49.000000000 +1100
> > +++ linux-work/arch/powerpc/platforms/40x/ppc40x_simple.c	2008-12-08 15:51:52.000000000 +1100
> > @@ -61,7 +61,9 @@ static int __init ppc40x_probe(void)
> >  
> >  	for (i = 0; i < ARRAY_SIZE(board); i++) {
> >  		if (of_flat_dt_is_compatible(root, board[i])) {
> > +#ifdef CONFIG_PCI
> >  			ppc_pci_flags = PPC_PCI_REASSIGN_ALL_RSRC;
> > +#endif
> 
> No! #ifdefs! in C code!
> 
> To the tune of you-know-what.
> 
> Looks like we need an accessor we can replace with an empty version in
> the !PCI case.

If you have plenty of time on your hands :-) In the meantime, this is a
build fix.

Cheers,
Ben.





More information about the Linuxppc-dev mailing list