[PATCH 1/2] powerpc and sparc: Introduce dev_archdata node accessors
Michael Ellerman
michael at ellerman.id.au
Mon Dec 1 09:23:42 EST 2008
On Fri, 2008-11-28 at 22:13 +0300, Anton Vorontsov wrote:
> The name of the device_node field differ across the platforms, so we
> have to implement inlined accessors. This is needed to avoid ugly
> #ifdef in the generic code.
My grep skills may not be 1337 enough, but I only see maybe three uses
of arch_data.prom_node in arch/sparc:
# git grep "\.prom_node" arch/sparc/
arch/sparc/include/asm/fb.h: node = dev->archdata.prom_node;
arch/sparc/kernel/smp.c: cpu_data(id).prom_node = cpu_node;
arch/sparc/kernel/of_device.c: sd->prom_node = dp;
And about 15 in arch/powerpc.
Would it be simpler to have sparc use "of_node"? DaveM?
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20081201/cda5ab63/attachment.pgp>
More information about the Linuxppc-dev
mailing list