[PATCH v3 1/2] powerpc: Board support for GE Fanuc SBC610

[Kumar Gala]

On Aug 26, 2008, at 8:13 AM, Martyn Welch wrote:

> +
> +		PowerPC,8641 at 0 {
> +			device_type = "cpu";
> +			reg = <0x00000000>;
> +			d-cache-line-size = <32>;	// 32 bytes
> +			i-cache-line-size = <32>;	// 32 bytes
> +			d-cache-size = <32768>;		// L1, 32K
> +			i-cache-size = <32768>;		// L1, 32K

>
> +			timebase-frequency = <0>;	// From uboot
> +			bus-frequency = <0>;		// From uboot
> +			clock-frequency = <0>;		// From uboot

you can remove these since u-boot will set them.

>
> +		};
> +		PowerPC,8641 at 1 {
> +			device_type = "cpu";
> +			reg = <0x00000001>;
> +			d-cache-line-size = <32>;	// 32 bytes
> +			i-cache-line-size = <32>;	// 32 bytes
> +			d-cache-size = <32768>;		// L1, 32K
> +			i-cache-size = <32768>;		// L1, 32K

>
> +			timebase-frequency = <0>;	// From uboot
> +			bus-frequency = <0>;		// From uboot
> +			clock-frequency = <0>;		// From uboot

you can remove these since u-boot will set them.

>
> +		};
> +	};
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x40000000>;	// set by u-boot

if the comment is zero just set it to <0 0>;

>
> +	};
> +

what u-boot version are you using/shipping with these boards?   
Wondering if other props (like cache info, is set by u-boot for you).

- k