checkpatch nits ...

David Howells dhowells at redhat.com
Sun Aug 24 22:23:05 EST 2008


Kevin Diggs <kevdig at hypersurf.com> wrote:

> The entire block is:
> 
> 	__asm__ __volatile__ (
> 		"addi %0,%3,-1\n"
> 		"andc %1,%3,%0\n"
> 		"cntlzw %1,%1\n"
> 		"subfic %1,%1,31\n"
> 		"cntlzw %0,%2\n":
> 		"=r"(cntlz), "=r"(cnttz):
> 		"r"(tmp), "b"(cnttz)
> 	);

As long as this has no side effects, the __volatile__ isn't necessary.  If the
only effect is to produce the specified outputs based on the specified inputs,
the code can be moved or eliminated if the outputs aren't used.

David



More information about the Linuxppc-dev mailing list