checkpatch nits ...
Kevin Diggs
kevdig at hypersurf.com
Sat Aug 23 10:21:44 EST 2008
Hi,
Can I ignore these checkpatch errors:
ERROR: do not initialise statics to 0 or NULL
#829: FILE: powerpc/kernel/cpu/pll_if.c:61:
+static unsigned int override_bus_clock = 0;
ERROR: do not initialise externals to 0 or NULL
#1281: FILE: powerpc/kernel/cpu/pll_if.c:513:
+int rval = 0;
Someone (Arnd?) told me this was due to an older compiler putting these
in a strange section?
WARNING: externs should be avoided in .c files
#1137: FILE: powerpc/kernel/cpu/pll_if.c:369:
+ __asm__ __volatile__ (
??? I don't know what this is?
The entire block is:
__asm__ __volatile__ (
"addi %0,%3,-1\n"
"andc %1,%3,%0\n"
"cntlzw %1,%1\n"
"subfic %1,%1,31\n"
"cntlzw %0,%2\n":
"=r"(cntlz), "=r"(cnttz):
"r"(tmp), "b"(cnttz)
);
More information about the Linuxppc-dev
mailing list