[PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support

Josh Boyer jwboyer at linux.vnet.ibm.com
Thu Aug 21 03:11:24 EST 2008


On Wed, 20 Aug 2008 09:33:06 -0700
Roland Dreier <rdreier at cisco.com> wrote:

>  > You should fix 52xx with the same for loop change then, since I
>  > blatantly most of this file from you ;)
> 
> Heh, then factor out mpc5200_simple_probe() into a helper and use it
> instead of copying it as ppc44x_probe?  ;)
> 
> If you stick to the NULL-terminated array version, then it becomes easy
> to convert some other platform probing code to use your new code too, eg
> tqm85xx_probe() could use an array too.

Except that logically doesn't make much sense.  Why would you have a
list of mpc52xx and 44x boards together?  They require completely
different kernels because the MMU and drive set is entirely different.

Or am I totally missing what you are saying?

josh



More information about the Linuxppc-dev mailing list