[PATCH 1/2] port ndfc driver to of platform

Arnd Bergmann arnd at arndb.de
Fri Aug 15 17:27:41 EST 2008


On Friday 15 August 2008, Sean MacLennan wrote:
> Port the ndfc driver to an OF platform driver.
> 
> Signed-off-by: Sean MacLennan <smaclennan at pikatech.com>

Acked-by: Arnd Bergmann <arnd at arndb.de>

Looks great, but I just noticed one more detail:

> +static const struct of_device_id ndfc_match[] = {
> +	{ .compatible = "amcc,ndfc", },
> +	{}
>  };
>  

You should add

MODULE_DEVICE_TABLE(of, &ndfc_match);

to enable module auto-loading.

	Arnd <><



More information about the Linuxppc-dev mailing list