[PATCH 5121 pci 3/3] powerpc: pci: 5121: Hide pci bridge.

[Kumar Gala]

On Aug 13, 2008, at 12:16 AM, Grant Likely wrote:

> On Thu, Aug 07, 2008 at 11:36:27AM -0600, John Rigby wrote:
>> The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER
>> while other freescale host bridges have class set to
>> PCI_CLASS_PROCESSOR_POWERPC.
>>
>> This patch makes fixup_hide_host_resource_fsl match
>> PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC.
>>
>> Signed-off-by: John Rigby <jrigby at freescale.com>
>
> I think this is okay, but it might need to be more conservative.  I'm
> not the PCI expert.  Kumar, thoughts?

This is fine, since we qualify this with an FSL VendorID.

- k

>> ---
>> arch/powerpc/kernel/pci_32.c |    5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/ 
>> pci_32.c
>> index 88db4ff..162c3a8 100644
>> --- a/arch/powerpc/kernel/pci_32.c
>> +++ b/arch/powerpc/kernel/pci_32.c
>> @@ -54,11 +54,12 @@ LIST_HEAD(hose_list);
>> static int pci_bus_count;
>>
>> static void
>> -fixup_hide_host_resource_fsl(struct pci_dev* dev)
>> +fixup_hide_host_resource_fsl(struct pci_dev *dev)
>> {
>> 	int i, class = dev->class >> 8;
>>
>> -	if ((class == PCI_CLASS_PROCESSOR_POWERPC) &&
>> +	if ((class == PCI_CLASS_PROCESSOR_POWERPC ||
>> +	     class == PCI_CLASS_BRIDGE_OTHER) &&
>> 		(dev->hdr_type == PCI_HEADER_TYPE_NORMAL) &&
>> 		(dev->bus->parent == NULL)) {
>> 		for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
>> -- 
>>
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev at ozlabs.org
>> https://ozlabs.org/mailman/listinfo/linuxppc-dev