[PATCH 3/5] Apply relocation

Paul Mackerras paulus at samba.org
Wed Aug 13 15:11:06 EST 2008


Mohan Kumar M writes:

> This code is a wrapper around regular kernel. This checks whether the
> kernel is loaded at 32MB, if its not loaded at 32MB, its treated as a
> regular kernel and the control is given to the kernel immediately. If
> the kernel is loaded at 32MB, it applies relocation delta to each offset
> in the list which was generated and appended by patch 1 and 2. After
> updating all offsets, control is given to the relocatable kernel.

In patch 1, you output the addresses for three kinds of relocations,
but here you only seem to handle two (R_PPC64_ADDR64 and
R_PPC64_ADDR16_HI, I assume).  How does that work?

In general with this patch series, I would like to have seen much more
detailed patch descriptions.  I think most of these patches could have
used 4 or 5 paragraphs of description (or more if you like) telling us
things such as why you handle the particular relocations you do and
not others.

Paul.



More information about the Linuxppc-dev mailing list