[PATCH] pata_of_platform: fix no irq handling

Alan Cox alan at lxorguk.ukuu.org.uk
Tue Aug 12 02:29:16 EST 2008


On Mon, 11 Aug 2008 19:19:13 +0400
Anton Vorontsov <avorontsov at ru.mvista.com> wrote:

> When no irq specified, pata_of_platform fills irq_res with -1,
> which is wrong to do for two reasons:
> 
> 1. By definition, 'no irq' should be IRQ 0, not some negative integer;
> 2. pata_platform checks for irq_res.start > 0, but since irq_res.start
>    is unsigned type, the check will be true for `-1'.
> 
> Reported-by: Steven A. Falco <sfalco at harris.com>
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
Acked-by: Alan Cox <alan at redhat.com>



More information about the Linuxppc-dev mailing list