Strange tg3 regression with UMP fw. link reporting

Segher Boessenkool segher at kernel.crashing.org
Fri Aug 8 18:58:58 EST 2008


> I don't know yet for sure what happens, but a quick look at the commit
> seems to show that the driver synchronously spin-waits for up to 2.5ms

That's what the comment says, but the code says 2.5 _seconds_:

+       /* Wait for up to 2.5 milliseconds */
+       for (i = 0; i < 250000; i++) {
+               if (!(tr32(GRC_RX_CPU_EVENT) & GRC_RX_CPU_DRIVER_EVENT))
+                       break;
+               udelay(10);
+       }

(not that milliseconds wouldn't be bad already...)


Segher




More information about the Linuxppc-dev mailing list