[PATCH]: Remove bogons from the iSeries console

Adrian Bunk bunk at kernel.org
Thu Aug 7 02:57:30 EST 2008


On Thu, Aug 07, 2008 at 12:10:06AM +1000, Stephen Rothwell wrote:
> Hi Alan,
> 
> On Wed, 6 Aug 2008 14:06:29 +0100 Alan Cox <alan at lxorguk.ukuu.org.uk> wrote:
> >
> > The iSeries driver calls into the n_tty ldisc code directly for some
> > bizarre reason. I previously tagged this with a query but this actually
> > does need fixing as n_tty methods when you have a different ldisc set are
> > not a good thing to call.
> > 
> > In n_tty mode this change should have no effect, the core tty layer has
> > always called the ldisc ioctl method *anyway* and will call the one for
> > the right ldisc.
> > 
> > Signed-off-by: Alan Cox <alan at redhat.com>
> 
> I will take your word for it as I have no idea.  This driver needs to be
> deprecated anyway (in favour of hcv_iseries).
>...

You already marked it as "Obsolete" more than 2 years ago, and due the 
kconfig dependencies most people anyway won't even see the option (since 
they have HVC_ISERIES enabled).

IMHO a candidate for a straight removal?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed




More information about the Linuxppc-dev mailing list