[PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.

Grant Likely grant.likely at secretlab.ca
Wed Aug 6 07:12:59 EST 2008


On Tue, Aug 5, 2008 at 3:08 PM, Scott Wood <scottwood at freescale.com> wrote:
> Grant Likely wrote:
>>
>> Is it not sufficient to search the tree for a node with the
>> <chip>-immr compatible value?  I don't think this is the intended use
>> case of aliases.
>
> That get's really annoying in code that is meant to deal with multiple
> chips.  I don't think finding the network or serial node that corresponds to
> u-boot's enumeration is what it's meant for, either, but pretty much any
> alternative you can come up with has someone saying that it's not what
> *that* was meant for, either.

But finding nodes that meet a criteria *is* what compatible is for and
there is precedence for it.  All u-boot platforms are finding the node
by path right now, and so all of them need to be changed.  Changing
them to find by compatible that is set per-board or per-SoC makes
complete sense to me.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.



More information about the Linuxppc-dev mailing list