[2.6 patch] sata_fsl.c: fix 8315DS workaround

Li Yang LeoLi at freescale.com
Mon Aug 4 18:55:37 EST 2008


> -----Original Message-----
> From: Adrian Bunk [mailto:bunk at kernel.org] 
> Sent: Monday, August 04, 2008 4:46 PM
> To: Kalra Ashish; Li Yang; Jeff Garzik; galak at kernel.crashing.org
> Cc: linuxppc-dev at ozlabs.org; linux-ide at vger.kernel.org; 
> Robert P. J. Day
> Subject: [2.6 patch] sata_fsl.c: fix 8315DS workaround
> 
> Commit e7eac96e8f0e57a6e9f94943557bc2b23be31471 
> (ata/sata_fsl: Move MPC8315DS link speed limit workaround to 
> specific ifdef) aimed at limiting the workaround only to the 
> affected hardware, but since the #ifdef used a nonexisting 
> kconfig variable it actually killed the workaround.

This workaround is only for MPC8315_DS board which is not supported in the main line yet.  We can remove the workaround if we need to do something here.

- Leo

> 
> Reported-by: Robert P. J. Day <rpjday at crashcourse.ca>
> Signed-off-by: Adrian Bunk <bunk at kernel.org>
> 
> ---
> cd54dd8b6a8bca44ead212d12fe116702cc31ed7
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c 
> index 3924e72..45878ef 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -640,7 +640,7 @@ static int sata_fsl_port_start(struct 
> ata_port *ap)
>  	VPRINTK("HControl = 0x%x\n", ioread32(hcr_base + HCONTROL));
>  	VPRINTK("CHBA  = 0x%x\n", ioread32(hcr_base + CHBA));
>  
> -#ifdef CONFIG_MPC8315_DS
> +#ifdef CONFIG_MPC831x_RDB
>  	/*
>  	 * Workaround for 8315DS board 3gbps link-up issue,
>  	 * currently limit SATA port to GEN1 speed
> 
> 


More information about the Linuxppc-dev mailing list