[PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT
Timur Tabi
timur at freescale.com
Fri Aug 1 07:10:10 EST 2008
Jon Smirl wrote:
> But that's the same as saying we should copy the system clock
> frequency into all of the PSC nodes because we might implement
> hardware where they aren't all clocked off from the same input clock
> source.
The I2C clock is only visible to the I2C devices. The system clock is seen by
many devices. There's the difference.
>> > Aren't we talking about the /2 or /3 or /1 divider that appears to be
>> > randomly implemented on various members of the mpc8xxx family?
>
> I don't this these dividers or clocks need to be exposed at all if
> you'd just put that ugly code snippet into your platform driver.
That's why I don't think the divider belongs in the device tree. Just put the
actual resulting clock frequency in the device tree.
Besides, putting that snippet in the platform driver *is* exposing it.
--
Timur Tabi
Linux kernel developer at Freescale
More information about the Linuxppc-dev
mailing list