[PATCH 2/7] Celleb: Move pause, kexec_cpu_down to beat.c

Ishizaki Kou kou.ishizaki at toshiba.co.jp
Thu Sep 27 18:27:16 EST 2007


> On Wednesday 26 September 2007, Ishizaki Kou wrote:
> > This patch is an update for "Beat on Celleb"
> >   - Move beat_pause(), beat_kexec_cpu_down() from setup.c to beat.c
> >=20
> > Signed-off-by: <Kou.Ishizaki at toshiba.co.jp>
>=20
> Acked-by: Arnd Bergmann <arnd.bergmann at de.ibm.com>
>=20
> The patch looks good, once you fix this one line:
>=20
> > @@ -36,5 +36,9 @@ ssize_t beat_nvram_get_size(void);
> >  ssize_t beat_nvram_read(char *, size_t, loff_t *);
> >  ssize_t beat_nvram_write(char *, size_t, loff_t *);
> >  int beat_set_xdabr(unsigned long);
> > +void beat_power_save(void);
> > +#ifdef CONFIG_KEXEC
> > +void beat_kexec_cpu_down(int, int);
> > +#endif
>=20
> Function declarations in headers files should not be enclosed in =
#ifdef,
> it only causes unnecessary rebuilds when the configuration changes, =
but
> does not help.

Agreed. I'll post an updated patch.

Best regards,
Kou Ishizaki



More information about the Linuxppc-dev mailing list