[PATCH v2] Make instruction dumping work in real mode.
galak at kernel.crashing.org
Wed Sep 26 14:06:49 EST 2007
On Sep 25, 2007, at 3:19 PM, Scott Wood wrote:
> On non-book-E-or-4xx, exceptions execute in real mode. If a fault
> that leads to a register dump, the kernel currently prints XXXXXXXX
> it doesn't realize that PC is a physical address.
> This patch checks the state of the IMMU, and if necessary converts
> PC into a
> virtual address.
> Signed-off-by: Scott Wood <scottwood at freescale.com>
> This version uses MSR_IR rather than address heuristics, and fixes
> that somehow crept into the address adjustment in the previous patch.
> arch/powerpc/kernel/process.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/
> index 57c589c..6dbde7f 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -354,6 +354,14 @@ static void show_instructions(struct pt_regs
> if (!(i % 8))
> +#if !defined(CONFIG_BOOKE) && !defined(CONFIG_40x)
40x has a real mode and can have the IMMU off.
> + /* If executing with the IMMU off, adjust pc rather
> + * than print XXXXXXXX.
> + */
> + if (!(regs->msr & MSR_IR))
> + pc = (unsigned long)phys_to_virt(pc);
> /* We use __get_user here *only* to avoid an OOPS on a
> * bad address because the pc *should* only be a
> * kernel address.
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
More information about the Linuxppc-dev