[spi-devel-general] [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx
galak at kernel.crashing.org
Wed Sep 26 14:00:38 EST 2007
On Sep 25, 2007, at 11:58 AM, David Brownell wrote:
>>>> - depends on SPI_MASTER && PPC_83xx && EXPERIMENTAL
>>>> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL
>>> Should that really be just PPC_83xx || QUICC_ENGINE?
>> Well, I thought about that. By now I'm unsure if every QE
>> implementation will be compatible with further ones.
> How many other QE implementations exist? Is that sort of
> gratuitous breakage something Freescale makes a habit of?
We try not to, but HW people are know to do evil things to keep us
software guys employed.
>> So far
>> I've tested this driver on MPC8323 and MPC8568. If we'll see
>> more and more compatible QE SPI controllers, of course we
>> may just do || QUICC_ENGINE.
>> PPC_83xx || PPC_85xx
>> PPC_83xx || QUICC_ENGINE
>> Today first option saves us four bytes. ;-)
> It'd be good if someone would look at the relevant docs.
> I'll wait for a PPC signoff before I forward this for
> merge with SPI stuff...
I'm still in favor of making it PPC_83xx || QUICC_ENGINE.
So if when we have 87xx with QUICC_ENGINE we don't have to tweak it
again, but its a minor thing.
More information about the Linuxppc-dev