[PATCH v2 2/4] Implement generic time of day clocksource for powerpc machines.

[Stephen Rothwell]

Small comments.

On Fri, 21 Sep 2007 13:26:02 +1000 Tony Breeds <tony at bakeyournoodle.com> wrote:
>
> +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
> +{
> +	u64 t2x, stamp_xsec;
> +
> +	if (__USE_RTC() || clock != &clocksource_timebase)
            ^^^^^^^^^^^
I think this is redundant as if __USE_RTC() is true, you register
clocksource_rtc below.

> +#ifdef CONFIG_ISERIES
> +	if (!firmware_has_feature(FW_FEATURE_ISERIES))
> +#endif

The #ifdef is redundant since if CONFIG_ISERIES is not set,
firmware_has_feature(FW_FEATURE_ISERIES) is constant 0.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070921/989796c3/attachment.pgp>