Sequoia kernel crash workaround.
Olof Johansson
olof at lixom.net
Thu Sep 20 05:30:24 EST 2007
On Wed, Sep 19, 2007 at 09:19:47PM +0200, Stefan Roese wrote:
> Hi Valentine,
>
> On Wednesday 19 September 2007, Valentine Barshak wrote:
> > Disabling write pipelining really helps.
> > Josh, David, what is the right place to put this workaround to?
> >
> > Is it OK to do mtdcr(PLB4A0_ACR, mfdcr(PLB4A0_ACR) & ~PLB4_WRP); in
> > arch/powerpc/boot/cuboot-sequoia.c:sequoia_fixups()?
> > or
> > should this be done in
> > arch/powerpc/platforms/44x/sequoia.c:sequoia_setup_arch()
> > with dcr_map, dcr_read/write stuff?
>
> I vote for putting it into sequoia.c, since it's very likely to happen that
> Sequoia will at one point be booted without the bootwrapper. Or perhaps it
> should go into some common code checking the PVR and disabling it when this
> 440EPx/GRx is detected, since all those boards are affected.
This is what we have setup_cpu functions in the cpu table for. Please
put it there instead of in board code.
-Olof
More information about the Linuxppc-dev
mailing list