[PATCH 01/28] CPM: Change from fsl, brg-frequency to brg/clock-frequency

David Gibson david at gibson.dropbear.id.au
Wed Sep 19 09:48:01 EST 2007


On Tue, Sep 18, 2007 at 09:21:50AM -0500, Scott Wood wrote:
> On Tue, Sep 18, 2007 at 04:11:41PM +1000, David Gibson wrote:
> > > +	/* Legacy device binding -- will go away when no users are left. */
> > > +	node = of_find_node_by_type(NULL, "cpm");
> > > +	if (node) {
> > > +		prop = of_get_property(node, "brg-frequency", &size);
> > 
> > Shouldn't you check for "fsl,brg-frequency" here, in case of old
> > device trees?
> 
> What old device trees?  fsl,brg-frequency has never hit mainline; it's
> only been in Kumar's tree for a week or so.

Ah, ok.  I didn't realise.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list