[PATCH 16/28] 8xx: Don't call non-existent Soft_emulate_8xx from SoftwareEmulation.

Kumar Gala galak at kernel.crashing.org
Wed Sep 19 01:19:05 EST 2007

On Sep 18, 2007, at 10:11 AM, Scott Wood wrote:

> On Tue, Sep 18, 2007 at 10:08:50AM -0500, Kumar Gala wrote:
>> On Sep 17, 2007, at 11:57 AM, Scott Wood wrote:
>>> On arch/ppc, Soft_emulate_8xx was used when full math emulation was
>>> turned off to emulate a minimal subset of floating point load/store
>>> instructions, to avoid needing a soft-float toolchain.  This  
>>> function
>>> is called, but not present, on arch/powerpc, causing a build error
>>> if floating point emulation is turned off.
>>> As:
>>> 1. soft-float toolchains are now common,
>>> 2. partial emulation could mislead someone into thinking they have
>>> a soft-float userspace because things usually work, only to have it
>>> fail when actual FP gets executed under unusual circumstances, and
>>> 3. full emulation is still available for those who need to run
>>> non-soft-float userspace,
>>> I'm deleting the call rather than moving Soft_emulate_8xx over to
>>> arch/powerpc.
>>> Signed-off-by: Scott Wood <scottwood at freescale.com>
>> I'm still not in favor of this and think we should move the
>> Soft_emulate_8xx code over.
> Any particular reasons that outweigh the reasons I gave, especially  
> #2?

Mainly that 8xx has been doing this for a vast number of years and I  
see no reason to stop doing it at this point.

While I can see that it might be misleading, clearly 8xx linux users  
haven't had issues with it.

- k

More information about the Linuxppc-dev mailing list