[PATCH 1/3] usb: add device-tree-aware ehci driver

Josh Boyer jwboyer at jdub.homelinux.org
Tue Sep 18 00:00:39 EST 2007


On Mon, 17 Sep 2007 23:28:09 +1000
Stephen Rothwell <sfr at canb.auug.org.au> wrote:

> On Mon, 17 Sep 2007 16:55:43 +0400 Valentine Barshak <vbarshak at ru.mvista.com> wrote:
> >
> > +++ linux-2.6/drivers/usb/host/ehci-ppc-of.c	2007-09-15 16:12:56.000000000 +0400
> > @@ -0,0 +1,220 @@
> > +
> > +#include <asm/of_platform.h>
> > +#include <asm/prom.h>
> 
> Please use linux/of.h and linux/of_platform.h instead.

This seems to be a common error these days.  Perhaps a #warning in the
asm/ files if _LINUX_OF_PLATFORM_H and _LINUX_OF_H aren't defined would
be helpful.

josh



More information about the Linuxppc-dev mailing list