[PATCH 22/22] [POWERPC] MPC832x_RDB: Update dts to use SPI1 in QE, register mmc_spi stub

Kumar Gala galak at kernel.crashing.org
Fri Sep 14 23:50:16 EST 2007

On Sep 14, 2007, at 8:21 AM, Kumar Gala wrote:

> On Sep 14, 2007, at 7:32 AM, Paul Mackerras wrote:
>> Kumar Gala writes:
>>> From: Anton Vorontsov <avorontsov at ru.mvista.com>
>>> mmc_spi already tested to work. When it will hit mainline
>>> the only change that will be needed is replacing "spidev"
>>> with "mmc_spi".
>> That's a *remarkably* uninformative commit message.  And what's the
>> use of putting in something about "when it will hit mainline" when
>> this is the point where it hits mainline?
> Yeah, I was afraid of that when I glanced at Anton's patches.
> I think the comment is in reference to a mainline SPI subsystem
> change intended for 2.6.24.

Let me know how you want to handle this.  I see two options.

1. merge patch as is (with new commit message, see below)
2. drop patch for now and wait for mmc_spi to be merged.

Take a look at the following for Anton's comments on the situation:


How about a commit message like the following:

     [POWERPC] MPC832x_RDB: Update dts to use SPI1 in QE, register  
mmc_spi stub

     Enabled using SPI controller on the MPC832x RDB board.  We  
currently use
     a modalias of "spidev" as a place holder (replace with  
"mmc_spie") until
     the mmc_spi driver support is merged in.

     This gets us the ability to test SPI until then.

     Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
     Signed-off-by: Kumar Gala <galak at kernel.crashing.org>

- k

More information about the Linuxppc-dev mailing list