[PATCH 01/25] spufs: staticify file-internal functions & variables

Christoph Hellwig hch at lst.de
Fri Sep 14 17:42:53 EST 2007


On Fri, Sep 14, 2007 at 04:32:54PM +1000, Jeremy Kerr wrote:
> From: Sebastian Siewior <cbe-oss-dev at ml.breakpoint.cc>
> 
> There are a few symbols used only in one file within spufs; this change
> makes them static where suitable.
> 
> Signed-off-by: Sebastian Siewior <sebastian at breakpoint.cc>
> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>

Looks good.

> +static asmlinkage long do_spu_create(const char __user *pathname,
> +		unsigned int flags, mode_t mode, struct file *neighbor)

please drop the unessecary asmlinkage here, though.




More information about the Linuxppc-dev mailing list