[PATCH] [POWERPC] DTS cleanup
Kumar Gala
galak at kernel.crashing.org
Fri Sep 14 07:04:57 EST 2007
On Sep 13, 2007, at 11:56 AM, Segher Boessenkool wrote:
>>>> * built-in for non-standard buses (ISA, PCI)
>>>
>>> "built-in" is some weird CHRP property, so yes we don't need it
>>> or want it.
>>
>> Do you suggest we get ride of it from ISA nodes as well?
>
> Yes. You aren't CHRP so you don't have to follow the CHRP binding.
> Of course it is good to copy from that binding where it makes sense,
> but how is "built-in" useful to you?
>
>>>> * Fixed ranges on lite5200*
>>>
>>> This has a problem still:
>>>
>>>> model = "fsl,mpc5200";
>>>> compatible = "mpc5200";
>>>> revision = ""; // from bootloader
>>>> - #interrupt-cells = <3>;
>>>> device_type = "soc";
>>>> - ranges = <0 f0000000 f0010000>;
>>>> - reg = <f0000000 00010000>;
>>>> + ranges = <0 f0000000 0000c000>;
>>>> + reg = <f0000000 0000c000>;
>>>
>>> That makes "reg" and "ranges" identify an identical address range,
>>> which means no subnode can claim any address in that range, so the
>>> "ranges" property should go. Alternatively, the "reg" might be
>>> claiming too big a space.
>>>
>>> Which is it?
>>
>> Yeah, I think it should be 0x100 for the 'soc' regs on 52xx so
>> I'll set regs to that.
>
> Okido.
>
> Did I say "nice cleanups, thank you!" already? :-)
You did, and let me tell you I've had enough of cleaning up the .dts
for a while :)
Someone really needs to add some macro/preprocessor magic into DTC so
this is made a lot simpler.
- k
More information about the Linuxppc-dev
mailing list