[PATCH] [POWERPC] DTS cleanup

Kumar Gala galak at kernel.crashing.org
Thu Sep 13 13:08:33 EST 2007


On Sep 12, 2007, at 5:10 PM, Segher Boessenkool wrote:

>> * 32-bit in cpu node -- doesn't exist in any spec and not used by  
>> kernel
>
> Yeah.
>
>> * built-in for non-standard buses (ISA, PCI)
>
> "built-in" is some weird CHRP property, so yes we don't need it
> or want it.

Do you suggest we get ride of it from ISA nodes as well?

>
>> * Removed #interrupt-cells in places they don't need to be set
>
> Great :-)
>
>> * Fixed ranges on lite5200*
>
> This has a problem still:
>
>>  		model = "fsl,mpc5200";
>>  		compatible = "mpc5200";
>>  		revision = "";			// from bootloader
>> -		#interrupt-cells = <3>;
>>  		device_type = "soc";
>> -		ranges = <0 f0000000 f0010000>;
>> -		reg = <f0000000 00010000>;
>> +		ranges = <0 f0000000 0000c000>;
>> +		reg = <f0000000 0000c000>;
>
> That makes "reg" and "ranges" identify an identical address range,
> which means no subnode can claim any address in that range, so the
> "ranges" property should go.  Alternatively, the "reg" might be
> claiming too big a space.
>
> Which is it?

Yeah, I think it should be 0x100 for the 'soc' regs on 52xx so I'll  
set regs to that.

- k



More information about the Linuxppc-dev mailing list