[PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

Zhang Wei-r63237 Wei.Zhang at freescale.com
Tue Sep 11 20:10:53 EST 2007


> 
> If this is experimental, perhaps you should mark the depends line as
> such
> 	depends on on DMA_ENGINE && PPC && EXPERIMENTAL

I'll add EXPERIMENTAL for MPC83xx only.

> 
> [...]
> 
> >+
> >+	fsl_dma_memcpy_issue_pending(chan);
> >+	while (fsl_dma_is_complete(chan, cookie, NULL, NULL)
> >+			!= DMA_SUCCESS);
> 
> Again, is it possible to hang your thread here?
> 
> [...]

I'll add msleep here.

Thanks!

- zw



More information about the Linuxppc-dev mailing list