[PATCH 02/10] cpm2: Fix off-by-one error in setbrg().

Kumar Gala galak at kernel.crashing.org
Tue Sep 11 07:07:04 EST 2007


On Sep 10, 2007, at 2:44 PM, Scott Wood wrote:

> Kumar Gala wrote:
>> On Sep 5, 2007, at 2:29 PM, Scott Wood wrote:
>>> The hardware adds one to the BRG value to get the divider, so it  
>>> must
>>> be subtracted by software.  Without this patch, characters will  
>>> occasionally
>>> be corrupted.
>>>
>>> Signed-off-by: Scott Wood <scottwood at freescale.com>
>>> ---
>>>  arch/powerpc/sysdev/cpm2_common.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> What was this patch against?
>> I ended up applying it by hand for 2.6.23 since its fixing a  
>> bug..  But, I'm wondering if there was a base set of changes this  
>> patchset was against?
>
> It was against head-of-your-tree as of the time I sent it.

Odd, my top of tree doesn't use out_be32() for cpm_setbrg().

- k



More information about the Linuxppc-dev mailing list