[PATCH 8/9] 8xx: Adder 875 support

Segher Boessenkool segher at kernel.crashing.org
Fri Sep 7 05:32:50 EST 2007


>>>>>>> +	model = "Analogue & Micro Adder MPC875";
>>>>>>
>>>>>> This should probably be just "MPC875".
>>>>>
>>>>> There's more than one board with an MPC875 on it.
>>>>
>>>> "model" is the model name the vendor uses.  It isn't supposed to
>>>> be unique globally, nor does it say what CPU is on the board.
>>>
>>> The name the vendor uses is "Adder MPC875".  The name of the vendor 
>>> is
>>> "Analogue & Micro", which seems useful to include, even if it's not
>>> mandatory that it be globally unique.
>>
>> So it should be "Adder MPC875", then :-)
>
> Any particular reason to leave out potentially useful information in a
> field that is for human consumption?

Because it isn't for human consumption (only), and has well-defined
semantics (although slightly fuzzy).

> Other than Because Segher Says So(tm). :-)

"Because the OF standard says so" :-)


Segher




More information about the Linuxppc-dev mailing list