[PATCH] [powerpc v2] update xmon slb code
Paul Mackerras
paulus at samba.org
Wed Oct 31 12:42:11 EST 2007
Will Schmidt writes:
> This adds a bit more detail to the xmon SLB output. When the valid bit is
> set, This displays the ESID and VSID values, as well as decoding the
> segment size. (1T or 256M). This supresses the output for any slb entries
> that contain only zeros.
>
> sample output from power6 (1T segment support):
>
> 00 c000000008000000 40004f7ca3000500 1T ESID= c00000 VSID=40004f7ca3 LLP bits:100
The "4" at the top of the VSID is actually the B (segment size) field,
isn't it? Shouldn't that get masked off, since you have already
printed the segment size separately?
Also, if you removed the "bits" text, it would just about fit into 80
columns. I think "LLP" is sufficient, the "bits" is redundant.
Apart from that it looks good.
Regards,
Paul,
More information about the Linuxppc-dev
mailing list