PPC405GP Walnut irq patch
Josh Boyer
jwboyer at gmail.com
Wed Oct 31 12:40:15 EST 2007
On Tue, 30 Oct 2007 17:41:27 -0400
"Steven A. Falco" <sfalco at harris.com> wrote:
> From: "Steven A. Falco" <sfalco at harris.com>
> To: linuxppc-dev at ozlabs.org
> Subject: Re: PPC405GP Walnut irq patch
> Date: Tue, 30 Oct 2007 17:41:27 -0400
> Sender: linuxppc-dev-bounces+jwboyer=gmail.com at ozlabs.org
> User-Agent: Thunderbird 2.0.0.5 (X11/20070719)
>
> I realized that I should have done this from the root level. So here is
> the corrected patch.
>
> Signed-off-by: Steve Falco <sfalco at harris.com>
>
>
> Steven A. Falco wrote:
> > Hi - I have found a bug in the ARCH=powerpc Walnut BSP. The order of
> > the ethernet interrupts in the walnut.dts file doesn't match the
> > documentation. I discovered this when porting the BSP to a custom
> > board - the ethernet would not work. The attached patch corrects that.
> >
> > This is the first patch I am submitting, so please advise me if there
> > is anything I should do differently.
> >
> > Signed-off-by: Steve Falco <sfalco at harris.com>
> >
> >
>
> diff --git a/arch/powerpc/boot/dts/walnut.dts b/arch/powerpc/boot/dts/walnut.dts
> index 27bef06..dd65115 100644
> --- a/arch/powerpc/boot/dts/walnut.dts
> +++ b/arch/powerpc/boot/dts/walnut.dts
> @@ -67,7 +67,7 @@
> num-tx-chans = <2>;
> num-rx-chans = <1>;
> interrupt-parent = <&UIC0>;
> - interrupts = <a 4 b 4 c 4 d 4 e 4>;
> + interrupts = <b 4 c 4 a 4 d 4 e 4>;
> };
I fixed this part already. Seems your tree is slightly old.
>
> POB0: opb {
> @@ -117,7 +117,7 @@
> device_type = "network";
> compatible = "ibm,emac-405gp", "ibm,emac";
> interrupt-parent = <&UIC0>;
> - interrupts = <9 4 f 4>;
> + interrupts = <f 4 9 4>;
Could you redo the patch with just this bit and send it again?
josh
More information about the Linuxppc-dev
mailing list