[PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines
Dale Farnsworth
dale at farnsworth.org
Tue Oct 30 21:22:57 EST 2007
On Tue, Oct 30, 2007 at 10:36:06AM +0100, Sven Luther wrote:
> On Tue, Oct 30, 2007 at 03:44:59AM -0400, Luis R. Rodriguez wrote:
> > On 10/29/07, Dale Farnsworth <dale at farnsworth.org> wrote:
> > > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote:
> > > > This commit made an incorrect assumption:
> > > > --
> > > > Author: Lennert Buytenhek <buytenh at wantstofly.org>
> > > > Date: Fri Oct 19 04:10:10 2007 +0200
> > > >
> > > > mv643xx_eth: Move ethernet register definitions into private header
> > > >
> > > > Move the mv643xx's ethernet-related register definitions from
> > > > include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since
> > > > they aren't of any use outside the ethernet driver.
> > > >
> > > > Signed-off-by: Lennert Buytenhek <buytenh at marvell.com>
> > > > Acked-by: Tzachi Perelstein <tzachi at marvell.com>
> > > > Signed-off-by: Dale Farnsworth <dale at farnsworth.org>
> > > > --
> > > >
> > > > arch/powerpc/platforms/chrp/pegasos_eth.c made use of a 3 defines there.
> > > >
> > > > mcgrof at pogo:~/devel/wireless-2.6$ git-describe
> > > >
> > > > v2.6.24-rc1-138-g0119130
> > > >
> > > > This patch fixes this by internalizing 3 defines onto pegasos which are
> > > > simply no longer available elsewhere. Without this your compile will fail
> > >
> > > That compile failure was fixed in commit
> > > 30e69bf4cce16d4c2dcfd629a60fcd8e1aba9fee by Al Viro.
> > >
> > > However, as I examine that commit, I see that it defines offsets from
> > > the eth block in the chip, rather than the full chip registeri block
> > > as the Pegasos 2 code expects. So, I think it fixes the compile
> > > failure, but leaves the Pegasos 2 broken.
> > >
> > > Luis, do you have Pegasos 2 hardware? Can you (or anyone) verify that
> > > the following patch is needed for the Pegasos 2?
> >
> > Nope, sorry.
>
> I am busy right now, but have various pegasos machines available for
> testing. What exactly should i test ?
Thanks Sven.
Test whether an Ethernet port works at all. I think it's currently
broken, but should work with the patch I supplied.
-Dale
More information about the Linuxppc-dev
mailing list