[PATCH 01/16] Add of_get_next_parent()
David Miller
davem at davemloft.net
Fri Oct 26 20:38:03 EST 2007
From: Michael Ellerman <michael at ellerman.id.au>
Date: Fri, 26 Oct 2007 16:54:31 +1000 (EST)
> Iterating through a device node's parents is simple enough, but dealing
> with the refcounts properly is a little ugly, and replicating that logic
> is asking for someone to get it wrong or forget it all together, eg:
>
> while (dn != NULL) {
> /* loop body */
> tmp = of_get_parent(dn);
> of_node_put(dn);
> dn = tmp;
> }
>
> So add of_get_next_parent(), inspired by of_get_next_child(). The contract
> is that it returns the parent and drops the reference on the current node,
> this makes the loop look like:
>
> while (dn != NULL) {
> /* loop body */
> dn = of_get_next_parent(dn);
> }
>
> Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
Looks good to me:
Acked-by: David S. Miller <davem at davemloft.net>
More information about the Linuxppc-dev
mailing list