[PATCH 1/2] powerpc: prpmc2800 - Add MTD support

Mark A. Greer mgreer at mvista.com
Fri Oct 26 11:06:23 EST 2007


On Fri, Oct 26, 2007 at 10:23:53AM +1000, Stephen Rothwell wrote:
> Hi Mark,
> 
> On Thu, 25 Oct 2007 16:39:48 -0700 "Mark A. Greer" <mgreer at mvista.com> wrote:
> >
> > +static int __init prpmc2800_register_mtd(void)
> > +{
> > +	struct device_node *np = NULL;
>                               ^^^^^^^
> Not needed if you use for_each_compatible_node().
> 
> > +
> > +	while ((np = of_find_compatible_node(np, NULL, "cfi-flash")) != NULL)
> 
> 	for_each_compatible_node(np, NULL, "cfi-flash")
> 
> > +		of_platform_device_create(np, NULL, NULL);
> > +
> > +	of_node_put(np);
> 
> Not needed as np must be NULL when you get here.

Ah, yes, true on all points.  Thanks Stephen.
Update coming shortly...

Mark



More information about the Linuxppc-dev mailing list