[PATCH 09/11] [POWERPC] Motion-PRO: Add LED support.

Marian Balakowicz m8 at semihalf.com
Fri Oct 26 01:53:13 EST 2007


Grant Likely wrote:
...
>> +
>> +static int __init mpled_init(void)
>> +{
>> +       int i, error;
>> +
>> +       for (i = 0; i < sizeof(led) / sizeof(struct motionpro_led); i++){
>> +               led[i].reg_addr = mpc52xx_find_and_map(led[i].reg_compat);
> 
> Please use of-platform-bus bindings instead.  Let the of-platform bus
> take care of scanning the tree for you.  Don't do it manually.

Hm, let me try that instead, thanks for the suggestion.

Cheers,
m.



More information about the Linuxppc-dev mailing list