[PATCH] PowerPC 440EPx Sequoia USB OHCI DTS entry
Dale Farnsworth
dale at farnsworth.org
Wed Oct 24 22:08:04 EST 2007
On Wed, Oct 24, 2007 at 03:19:14PM +0400, Valentine Barshak wrote:
> Dale Farnsworth wrote:
> >Valentine wrote:
> >>Actually I also don't see much reason for the
> >>USB_OHCI_HCD_PPC_OF_BE/USB_OHCI_HCD_PPC_OF_LE stuff.
> >>Is this really needed?
> >
> >I think so. The SOC host controllers are BE and the PCI
> >host controllers are LE. Or, do you have an alternative
> >method of handling both types?
>
> Yes, PCI controllers are LE, but do we really need user-selectable
> USB_OHCI_HCD_PPC_OF_LE option, since USB_OHCI_LITTLE_ENDIAN is selected
> by default for USB_OHCI_HCD_PCI?
> The USB_OHCI_HCD_PPC_OF_LE/BE stuff is related to PPC OF glue only.
> I think it's useless. We should always enable
> USB_OHCI_BIG_ENDIAN_DESC and USB_OHCI_BIG_ENDIAN_MMIO for PPC OF
> and the real LE/BE implementation should be selected by the
> corresponding properties in the device tree.
I agree that they don't need to be user selectable. It is far preferable
to deduce their values from existing information, if possible.
-Dale
More information about the Linuxppc-dev
mailing list