[PATCH 02/11] [POWERPC] Add 'lpb' bus type for MPC5200	LocalPlus Bus
    Olof Johansson 
    olof at lixom.net
       
    Wed Oct 24 10:09:41 EST 2007
    
    
  
Hi,
On Wed, Oct 24, 2007 at 01:13:15AM +0200, Marian Balakowicz wrote:
> Signed-off-by: Marian Balakowicz <m8 at semihalf.com>
> ---
Your patch lacks any kind of description beyond the title. (I know, it's a
real simple patch, but a real simple description would do too :)
> --- a/arch/powerpc/kernel/of_platform.c
> +++ b/arch/powerpc/kernel/of_platform.c
> @@ -49,6 +49,7 @@ static struct of_device_id of_default_bus_ids[] = {
>  	{ .type = "plb4", },
>  	{ .type = "opb", },
>  	{ .type = "ebc", },
> +	{ .type = "lpb", },
I thought it was consensus to keep the new bus ids only in platform
code and not add them to the default list, and just pass that list in
to of_platform_bus_probe().
-Olof
    
    
More information about the Linuxppc-dev
mailing list