[PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

David Miller davem at davemloft.net
Sat Oct 20 09:41:43 EST 2007


From: "Medve Emilian-EMMEDVE1" <Emilian.Medve at freescale.com>
Date: Fri, 19 Oct 2007 06:39:12 -0700

> For the current situation, 32-bit QE, 32-bit PowerPC, do you find
> the patch acceptable?

No piece of code in the kernel should live in a vacuum.

In order to improve overall code quality, every piece of
driver code should avoid assuming things about pointer
sizes and things of this nature.

Then the driver can get enabled into the build on every
platform, and therefore nobody will break the build of
this driver again since it will get hit by "allmodconfig"
et al. builds even on platforms other than the one it is
meant for.

This hack fix is not acceptable, really.



More information about the Linuxppc-dev mailing list